Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No namespaces #102

Merged
merged 1 commit into from
May 23, 2024
Merged

No namespaces #102

merged 1 commit into from
May 23, 2024

Conversation

avalentino
Copy link
Contributor

Disable setuptools implicit namespaces to avoid that doc/config.py is installed together with the donfig package.

@djhoese djhoese added the bug Something isn't working label May 14, 2024
@djhoese
Copy link
Member

djhoese commented May 14, 2024

Ok so you're saying the sdist had the conf.py and with this PR it doesn't? Thanks!

@codecov Codecov
Copy link

codecov bot commented May 14, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.28%. Comparing base (f542332) to head (7b90e4d).
Report is 21 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #102   +/-   ##
=======================================
  Coverage   98.28%   98.28%           
=======================================
  Files           6        6           
  Lines         759      759           
=======================================
  Hits          746      746           
  Misses         13       13
Flag Coverage Δ
unittests 98.28% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@avalentino
Copy link
Contributor Author

Ok so you're saying the sdist had the conf.py and with this PR it doesn't? Thanks!

no, it is fine to have it in sdist.
I'm saying that doc/config.py is installed in site-packages, which is not the desired behaviour I guess.

@djhoese
Copy link
Member

djhoese commented May 14, 2024

You're making me worried that every package I've moved from setup.py to pyproject.toml.

@avalentino
Copy link
Contributor Author

I think it is more a question of setuptools version

@djhoese djhoese merged commit 21b8d02 into pytroll:main May 23, 2024
9 checks passed
@avalentino avalentino deleted the bugfix/no-namespaces branch May 23, 2024 14:13
@djhoese
Copy link
Member

djhoese commented May 23, 2024

This is released as 0.8.1.post1 on PyPI now. Thanks again. Let me know if things still include extra files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@avalentino @djhoese